Showing AI reviews for crm-dashbaord
Project AI Score ?
73%
Quality Avg ?
74%
Security Avg ?
74%
Reviews ?
130

Review Result ?

solutionbowl/crm-dashbaord · 00808c24
This commit improves user experience by making volume checkboxes unchecked by default, hiding the volumes unless explicitly shown. It introduces new state handling for tracking visible volumes with Sets, applied consistently in two components. The implementation seems straightforward and unlikely to introduce bugs or security issues. However, the commit message is brief and could provide more context. The code could benefit from comments explaining the rationale, and unit tests to cover this behavior.
Quality ?
80%
Security ?
90%
Business Value ?
70%
Maintainability ?
80%
Issues & Suggested Fixes ?
1AI detects the issue
2Shows file, line, or evidence
3Suggests the fix to apply
Issue
Where commit message
Issue / Evidence issue
Suggested Fix expand commit message to clearly explain why volumes are unchecked by default and the expected impact
Lack Of Explanatory Comment
Where src/modules/horse/pages/Race/AdminRacepage.tsx:457
Issue / Evidence lack of explanatory comment
Suggested Fix add a comment explaining the purpose of showBackStaticVolMarketIds and showLayStaticVolMarketIds state variables
Lack Of Explanatory Comment
Where src/pages/Platforms/AdminMarketPage.tsx:557
Issue / Evidence lack of explanatory comment
Suggested Fix add a comment explaining the purpose of showBackStaticVolMarketIds and showLayStaticVolMarketIds state variables
Missing Test Coverage
Where src/modules/horse/pages/Race/AdminRacepage.tsx:562
Issue / Evidence no test coverage mentioned
Suggested Fix add unit or integration tests to verify volumes are hidden by default and toggle behavior works
Missing Test Coverage
Where src/pages/Platforms/AdminMarketPage.tsx:713
Issue / Evidence no test coverage mentioned
Suggested Fix add unit or integration tests to verify volumes are hidden by default and toggle behavior works
Code Change Preview · src/modules/horse/pages/Race/AdminRacepage.tsx ?
Removed / Before Commit
- diff --git a/src/modules/horse/pages/Race/AdminRacepage.tsx b/src/modules/horse/pages/Race/AdminRacepage.tsx
- index 00f162b..4608a28 100644
- const [selectedIds,    setSelectedIds]    = useState<Set<string>>(new Set());
- const [globalStates,   setGlobalStates]   = useState<Record<string, GlobalState>>({});
- const [percentColumnMarketIds, setPercentColumnMarketIds] = useState<Set<string>>(new Set());
-   const [hideBackStaticVolMarketIds, setHideBackStaticVolMarketIds] = useState<Set<string>>(new Set());
-   const [hideLayStaticVolMarketIds,  setHideLayStaticVolMarketIds]  = useState<Set<string>>(new Set());
- 
- useEffect(() => {
- if (selectedRaceId) fetchOdds(selectedRaceId);
- }, []);
- 
- const toggleBackStaticVol = useCallback((marketId: string, value: boolean) => {
-     setHideBackStaticVolMarketIds(prev => {
- const next = new Set(prev);
-       if (!value) next.add(marketId); // checkbox unchecked = hide
-       else next.delete(marketId);
- return next;
Added / After Commit
+ diff --git a/src/modules/horse/pages/Race/AdminRacepage.tsx b/src/modules/horse/pages/Race/AdminRacepage.tsx
+ index 00f162b..4608a28 100644
+ const [selectedIds,    setSelectedIds]    = useState<Set<string>>(new Set());
+ const [globalStates,   setGlobalStates]   = useState<Record<string, GlobalState>>({});
+ const [percentColumnMarketIds, setPercentColumnMarketIds] = useState<Set<string>>(new Set());
+   // Empty set = nothing shown = hidden by default. Add marketId to show the column.
+   const [showBackStaticVolMarketIds, setShowBackStaticVolMarketIds] = useState<Set<string>>(new Set());
+   const [showLayStaticVolMarketIds,  setShowLayStaticVolMarketIds]  = useState<Set<string>>(new Set());
+ 
+ useEffect(() => {
+ if (selectedRaceId) fetchOdds(selectedRaceId);
+ }, []);
+ 
+ const toggleBackStaticVol = useCallback((marketId: string, value: boolean) => {
+     setShowBackStaticVolMarketIds(prev => {
+ const next = new Set(prev);
+       if (value) next.add(marketId);    // checkbox checked = show
+       else next.delete(marketId);        // checkbox unchecked = hide
Removed / Before Commit
- diff --git a/src/pages/Platforms/AdminMarketPage.tsx b/src/pages/Platforms/AdminMarketPage.tsx
- index 481c861..7d83b9d 100644
- const [selectedIds,    setSelectedIds]    = useState<Set<string>>(new Set());
- const [globalStates,   setGlobalStates]   = useState<Record<string, GlobalState>>({});
- const [percentColumnMarketIds, setPercentColumnMarketIds] = useState<Set<string>>(new Set());
-   const [hideBackStaticVolMarketIds, setHideBackStaticVolMarketIds] = useState<Set<string>>(new Set());
-   const [hideLayStaticVolMarketIds,  setHideLayStaticVolMarketIds]  = useState<Set<string>>(new Set());
- const [confirmedWithdrawnRunnerKeys, setConfirmedWithdrawnRunnerKeys] = useState<Set<string>>(new Set());
- const assignedRacesLoadedRef = useRef(false);
- const permissionsKey = permissions.join(",");
- }, []);
- 
- const toggleBackStaticVol = useCallback((marketId: string, value: boolean) => {
-     setHideBackStaticVolMarketIds(prev => {
- const next = new Set(prev);
-       if (!value) next.add(marketId); // checkbox unchecked = hide
-       else next.delete(marketId);
- return next;
Added / After Commit
+ diff --git a/src/pages/Platforms/AdminMarketPage.tsx b/src/pages/Platforms/AdminMarketPage.tsx
+ index 481c861..7d83b9d 100644
+ const [selectedIds,    setSelectedIds]    = useState<Set<string>>(new Set());
+ const [globalStates,   setGlobalStates]   = useState<Record<string, GlobalState>>({});
+ const [percentColumnMarketIds, setPercentColumnMarketIds] = useState<Set<string>>(new Set());
+   // Empty set = nothing shown = hidden by default. Add marketId to show the column.
+   const [showBackStaticVolMarketIds, setShowBackStaticVolMarketIds] = useState<Set<string>>(new Set());
+   const [showLayStaticVolMarketIds,  setShowLayStaticVolMarketIds]  = useState<Set<string>>(new Set());
+ const [confirmedWithdrawnRunnerKeys, setConfirmedWithdrawnRunnerKeys] = useState<Set<string>>(new Set());
+ const assignedRacesLoadedRef = useRef(false);
+ const permissionsKey = permissions.join(",");
+ }, []);
+ 
+ const toggleBackStaticVol = useCallback((marketId: string, value: boolean) => {
+     setShowBackStaticVolMarketIds(prev => {
+ const next = new Set(prev);
+       if (value) next.add(marketId);    // checkbox checked = show
+       else next.delete(marketId);        // checkbox unchecked = hide