AI Review Center

Commit Review Workspace ?

Select a commit on the left to inspect quality, security, business value, findings, and suggested code changes.
Showing AI reviews for army
Project AI Score ?
67%
Quality Avg ?
72%
Security Avg ?
54%
Reviews ?
37

Review Result ?

jattin01/army · 447ee77b
The commit adds date range filtering logic for multiple date fields in the EquipmentReportController and corresponding UI date pickers. It improves feature completeness for filtering reports by dates and adds a new relationship in QaInspectionInitate model. However, error handling is minimal and inconsistent, and there is code duplication across similar date parsing blocks. The UI code uses different date range formats inconsistently. Minor bugs such as potential wrong variable use in blade template exist.
Quality ?
70%
Security ?
50%
Business Value ?
85%
Maintainability ?
65%
Issues & Suggested Fixes ?
1AI detects the issue
2Shows file, line, or evidence
3Suggests the fix to apply
Duplicate Logic
Where app/Http/Controllers/EquipmentReportController.php:120
Issue / Evidence duplicated date range parsing code for wcn_date
Suggested Fix refactor to a reusable method to improve quality and reduce bug risk
Inconsistent Use Of Date Formats For Job D...
Where app/Http/Controllers/EquipmentReportController.php:135
Issue / Evidence inconsistent use of date formats for job_date and control_date (d M Y) vs wcn_date (Y-m-d)
Suggested Fix unify date formats to improve quality and reduce bug risk
Catch Block For Invalid Date Format Swallo...
Where app/Http/Controllers/EquipmentReportController.php:129
Issue / Evidence catch block for invalid date format swallows errors silently
Suggested Fix add logging or user feedback to improve quality and debugging
Incorrect Variable Used In Option Selectio...
Where resources/views/eq-report/index.blade.php:127
Issue / Evidence incorrect variable used in option selection (compare request('wcn_no') == jobno instead of wcnno)
Suggested Fix fix variable to improve quality and reduce UI bugs
Locale Option 'Format' Is Deprecated In Da...
Where resources/views/eq-report/index.blade.php:455
Issue / Evidence locale option 'format' is deprecated in daterangepicker
Suggested Fix update to use 'dateFormat' as per current library standards to improve quality
Date Picker Inserts 'To' Separator Between...
Where resources/views/eq-report/index.blade.php:472
Issue / Evidence date picker inserts 'to' separator between dates, but controller expects '
Suggested Fix ' separator
Date Picker Inserts '
Where resources/views/eq-report/index.blade.php:497
Issue / Evidence date picker inserts '
Suggested Fix ' separator inconsistent with other datepickers using 'to'
Inconsistent Exception Comments Refer To '...
Where app/Http/Controllers/EquipmentReportController.php:151
Issue / Evidence inconsistent exception comments refer to 'job_date' in control_date catch block
Suggested Fix correct comments to improve maintainability
Missing Test Coverage
Where app/Models/QaInspectionInitate.php:49
Issue / Evidence newly added latestRepair relationship method lacks PHPDoc comments
Suggested Fix add documentation for maintainability and clarity
Code Change Preview · app/Http/Controllers/EquipmentReportController.php ?
Removed / Before Commit
- $filtersApplied = $request->except(['page', 'export']);
- $filtersApplied = array_filter($filtersApplied);
- 
- $query = WorkEquipment::with([
- 'workOrder.workUnit.units',
- 'workOrder.workUnit.wksps',
- }
- 
- if ($request->filled('wcn_date')) {
-             [$start, $end] = explode(' - ', $request->wcn_date);
-             $startDate = Carbon::createFromFormat('d M Y', trim($start))->startOfDay();
-             $endDate = Carbon::createFromFormat('d M Y', trim($end))->endOfDay();
- $query->whereBetween('wcn_date', [$startDate, $endDate]);
- }
- 
-         if ($request->filled('job_date')) {
-             [$start, $end] = explode(' - ', $request->job_date);
-             $startDate = Carbon::createFromFormat('d M Y', trim($start))->format('d-M-Y');
Added / After Commit
+ $filtersApplied = $request->except(['page', 'export']);
+ $filtersApplied = array_filter($filtersApplied);
+ 
+ 
+ $query = WorkEquipment::with([
+ 'workOrder.workUnit.units',
+ 'workOrder.workUnit.wksps',
+ }
+ 
+ if ($request->filled('wcn_date')) {
+     $dateRange = $request->wcn_date;
+ 
+     if (str_contains($dateRange, ' - ')) {
+         [$start, $end] = explode(' - ', $dateRange);
+ 
+         try {
+             $startDate = \Carbon\Carbon::createFromFormat('Y-m-d', trim($start))->startOfDay();
+             $endDate = \Carbon\Carbon::createFromFormat('Y-m-d', trim($end))->endOfDay();
Removed / Before Commit
- // ✅ 1. Show all inspections with basic filters
- public function index(Request $request)
- {
-     $initiations = QaInspectionInitate::with(['workOrder', 'workEquipment', 'vir', 'mr'])
- ->whereNotExists(function ($query) {
- $query->select(DB::raw(1))
- ->from('qa_inspections')
Added / After Commit
+ // ✅ 1. Show all inspections with basic filters
+ public function index(Request $request)
+ {
+     $initiations = QaInspectionInitate::with(['workOrder', 'workEquipment', 'vir', 'mr','latestRepair'])
+ ->whereNotExists(function ($query) {
+ $query->select(DB::raw(1))
+ ->from('qa_inspections')
Removed / Before Commit
- {
- return $this->belongsTo(User::class);
- }
- }
Added / After Commit
+ {
+ return $this->belongsTo(User::class);
+ }
+ 
+     public function latestRepair()
+ {
+     return $this->hasOne(EquipmentRepair::class, 'work_equipment_id', 'work_equipment_id')->latestOfMany();
+ }
+ 
+ }
Removed / Before Commit
- <div class="row">
- @php
- $filters = [
-                                 'unit_name' => $unitNames,
-                                 'group_name' => $groupNames,
-                                 'command_name' => $commands,
-                                 'workspace' => $workspaces,
-                                 'division' => $divisions,
- 'corps' => $corpsList,
-                                 'cos' => $cosList,
- 'repair_class' => $repairClasses,
- 'main_eqpt' => $mainEquipments,
- 'sub_eqpt' => $subEquipments,
- 'control_number' => $controlNumbers,
-                                 'job_no' => $jobs,
-                                 'wcn_no' => $wcns,
-                                 'regd_no' => $regdNos,
- ];
Added / After Commit
+ <div class="row">
+ @php
+ $filters = [
+                                 'unit' => $unitNames,
+                                 'wksp' => $workspaces,
+                                 'command' => $commands,
+ 'corps' => $corpsList,
+                                 'div' => $divisions,
+                                 'group_name' => $groupNames,
+ 'repair_class' => $repairClasses,
+ 'main_eqpt' => $mainEquipments,
+                                 'regd_no' => $regdNos,
+ 'sub_eqpt' => $subEquipments,
+ 'control_number' => $controlNumbers,
+ ];
+ $statuses = ['AWAITING JOB NO', 'AWAITING QC CONTROLL NO', 'UNDER REPAIR', 'UNDER VIR', 'UNDER WCN PROCESS', 'VIR REJECTED']
+ 
+ </div>
Removed / Before Commit
- <div class="card">
- <div class="card-header py-3">
- <div class="row align-items-center">
-                 <div class="col-md-12">
-                     <h4><b>QA Inspection Listing</b></h4>
- </div>
- </div>
- </div>
- <hr>
- <div class="card-body">
- <div class="container-fluid">
- 
- 
-     <!-- 🔍 Filter -->
- <form method="GET" action="{{ route('qa-inspections.index') }}" class="row g-3 mb-4">
-     <div class="col-md-3">
-         <label for="job_number" class="form-label">Job Number</label>
-         <select name="job_number" class="form-select select2" data-placeholder="Select or search Job Number">
Added / After Commit
+ <div class="card">
+ <div class="card-header py-3">
+ <div class="row align-items-center">
+                 <div class="col-md-5">
+                     <h4><b>QA Inspection</b></h4>
+ </div>
+                 <div class="col-md-7">
+                     <form method="GET" action="{{ route('qa-inspections.index') }}" class="mb-1">
+                         <div class="row align-items-end">
+                             <div class="col-md-5">
+                                 <label for="job_number" class="form-label">Job Number</label>
+                                 <select name="job_number" class="form-select select2" data-placeholder="Select or search Job Number">
+                                     <option value="">-- Select Job Number --</option>
+                                     @foreach($jobNumbers as $jobNo)
+                                         <option value="{{ $jobNo }}" {{ request('job_number') == $jobNo ? 'selected' : '' }}>
+                                             {{ $jobNo }}
+                                         </option>
+                                     @endforeach
Removed / Before Commit
- <div class="card">
- <div class="card-header py-3">
- <div class="row align-items-center">
-             <div class="col-md-6">
- <h4><b>QA Remark</b></h4>
- </div>
-             <div class="col-md-6 text-end">
-                 
- </div>
- </div>
- </div>
- <div class="card-body">
- <div class="container-fluid">
- 
-     <!-- 🔍 Filter Form (optional) -->
-     <form method="GET" action="{{ route('qa.index') }}" class="row g-3 mb-4">
-     <div class="col-md-3">
-         <label for="control_number" class="form-label">Control Number</label>
Added / After Commit
+ <div class="card">
+ <div class="card-header py-3">
+ <div class="row align-items-center">
+             <div class="col-md-5">
+ <h4><b>QA Remark</b></h4>
+ </div>
+             <div class="col-md-7">
+                <form method="GET" action="{{ route('qa.index') }}"class="mb-1">
+                     <div class="row align-items-end">
+                         <div class="col-md-5">
+                             <label for="control_number" class="form-label">Control Number</label>
+                             <select name="control_number" class="form-select select2" data-placeholder="Select or search Control No">
+                                 <option value="">-- Select Control Number --</option>
+                                 @foreach($controlNumbers as $number)
+                                     <option value="{{ $number }}" {{ request('control_number') == $number ? 'selected' : '' }}>
+                                         {{ $number }}
+                                     </option>
+                                 @endforeach
Removed / Before Commit
- </ul>
- </div>
- @endif
-         <div class="card">
-                     <div class="card-header py-3">
-                                 <div class="row align-items-center">
-                                     <div class="col-md-12">
-                                         <h4><b>QC Inspection Listing</b></h4>
-                                     </div>
-                                     
-                                 </div>
-                             </div>
-                     <hr>
- 
-             
-             <div class="card-body">
-                 <div class="container-fluid">
-
Added / After Commit
+ </ul>
+ </div>
+ @endif
+ <div class="card">
+     <div class="card-header py-3">
+         <div class="row align-items-center">
+             <div class="col-md-5">
+                 <h4><b>QC Inspection</b></h4>
+             </div>
+             <div class="col-md-7">
+                 <form method="GET" action="{{ route('qc-inspection.index') }}" class="mb-1">
+                     <div class="row align-items-end">
+                         <div class="col-md-5">
+                             <label for="job_number" class="form-label">Job Number</label>
+                             <select name="job_number" class="form-select select2" data-placeholder="Select or search Job Number">
+                                 <option value="">-- Select Job Number --</option>
+                                 @foreach($jobNumbers as $jobNo)
+                                     <option value="{{ $jobNo }}" {{ request('job_number') == $jobNo ? 'selected' : '' }}>
Removed / Before Commit
- <div class="card">
- <div class="card-header py-3">
- <div class="row align-items-center">
-                                     <div class="col-md-12">
- <h4><b>Quality Control Number</b></h4>
- </div>
- </div>
- </div>
- <hr>
- 
- <div class="card-body">
- <div class="container-fluid">
- 
-    <form method="GET" action="{{ route('qc.index') }}" class="row g-3 mb-4">
-     <div class="col-md-3">
-         <label for="job_no" class="form-label">Job Number</label>
-         <select name="job_no" class="form-select select2" data-placeholder="Select or search Job Number">
-             <option value="">-- Select Job No --</option>
Added / After Commit
+ <div class="card">
+ <div class="card-header py-3">
+ <div class="row align-items-center">
+                                     <div class="col-md-5">
+ <h4><b>Quality Control Number</b></h4>
+ </div>
+                                      <div class="col-md-7">
+                                        <form method="GET" action="{{ route('qc.index') }}" class="mb-1">
+                                          <div class="row align-items-end">
+                                             <div class="col-md-5">
+                                                 <label for="job_no" class="form-label">Job Number</label>
+                                                 <select name="job_no" class="form-select select2" data-placeholder="Select or search Job Number">
+                                                     <option value="">-- Select Job No --</option>
+                                                     @foreach($jobNumbers as $jobNo)
+                                                         <option value="{{ $jobNo }}" {{ request('job_no') == $jobNo ? 'selected' : '' }}>
+                                                             {{ $jobNo }}
+                                                         </option>
+                                                     @endforeach
Removed / Before Commit
- <table class="table table-bordered">
- <thead class="table-primary">
- <tr>
-                         <th>Repair Progress Update Date</th>
- <th>Fault</th>
-                         <th>Repair Progress Remark</th>
- <th>PDC Date</th>
- </tr>
- </thead>
Added / After Commit
+ <table class="table table-bordered">
+ <thead class="table-primary">
+ <tr>
+                         <th>Update On</th>
+ <th>Fault</th>
+                         <th>Repair Progress</th>
+ <th>PDC Date</th>
+ </tr>
+ </thead>
Removed / Before Commit
- <div class="card">
- <div class="card-header py-3">
- <div class="row align-items-center">
-             <div class="col-md-12">
- <h4><b>Equipment Repair Progress</b></h4>
- </div>
- </div>
- </div>
- <hr>
- <div class="card-body">
- <div class="container-fluid">
- 
-     <form method="GET" action="{{ route('repairs.index') }}" class="row g-3 mb-4">
-     <div class="col-md-3">
-         <select name="job_number" class="form-select select2">
-             <option value="">-- Select Job Number --</option>
-             @foreach ($jobNumbers as $job)
-                 <option value="{{ $job }}" {{ request('job_number') == $job ? 'selected' : '' }}>
Added / After Commit
+ <div class="card">
+ <div class="card-header py-3">
+ <div class="row align-items-center">
+             <div class="col-md-5">
+ <h4><b>Equipment Repair Progress</b></h4>
+ </div>
+             <div class="col-md-7">
+                 <form method="GET" action="{{ route('repairs.index') }}" class="mb-1">
+                     <div class="row align-items-end">
+                         <div class="col-md-5">
+                             <label for="Job_number" class="form-label">Job Number</label>
+                             <select name="job_number" class="form-select select2">
+                                 <option value="">-- Select Job Number --</option>
+                                 @foreach ($jobNumbers as $job)
+                                     <option value="{{ $job }}" {{ request('job_number') == $job ? 'selected' : '' }}>
+                                         {{ $job }}
+                                     </option>
+                                 @endforeach
Removed / Before Commit
- <div class="card">
- <div class="card-header py-3">
- <div class="row align-items-center">
-             <div class="col-md-6">
- <h4><b>Awaiting VIR</b></h4>
- </div>
-             <div class="col-md-6 text-end">
-                 
- </div>
- </div>
- </div>
- <div class="card-body">
- <div class="container-fluid">
- 
- 
-     <!-- 🔍 Filter Form -->
-    <form method="GET" action="{{ route('vir.index') }}">
-     <div class="row align-items-end">
Added / After Commit
+ <div class="card">
+ <div class="card-header py-3">
+ <div class="row align-items-center">
+             <div class="col-md-5">
+ <h4><b>Awaiting VIR</b></h4>
+ </div>
+             <div class="col-md-7">
+                 <form method="GET" action="{{ route('vir.index') }}" class="mb-1">
+                     <div class="row align-items-end">
+                         {{-- Control Number --}}
+                         <div class="col-md-5">
+                             <label for="control_number" class="form-label">Control Number</label>
+                             <select name="control_number" class="form-select select2" data-placeholder="Search or select Control Number">
+                                 <option value="">-- Select Control Number --</option>
+                                 @foreach($controlNumbers as $number)
+                                     <option value="{{ $number }}" {{ request('control_number') == $number ? 'selected' : '' }}>
+                                         {{ $number }}
+                                     </option>
Removed / Before Commit
- </select>
- </div>
- <div class="col-md-3 d-flex align-items-end gap-2">
-                         <button type="submit" class="btn btn-filter">Filter</button>
- <a href="{{ route('wcn.index') }}" class="btn btn-info">Reset</a>
- </div>
- </form>
Added / After Commit
+ </select>
+ </div>
+ <div class="col-md-3 d-flex align-items-end gap-2">
+                         <button type="submit" class="btn btn-search btn-sm px-5 rounded-0">Search</button>
+ <a href="{{ route('wcn.index') }}" class="btn btn-info">Reset</a>
+ </div>
+ </form>
Removed / Before Commit
- {{-- Control Number --}}
- <div class="mb-2">
- <strong>Control Number:</strong><br>
-                     @php
-                         $masterName = App\Models\MasterLogo::first()?->name ?? 'NA';
-                     @endphp
-                     {{ $masterName . '/' . ($order->control_no ?? 'NA') . ' DT ' . ($order->control_date ?? 'NA') }}
- </div>
- </div>
- </div>
Added / After Commit
+ {{-- Control Number --}}
+ <div class="mb-2">
+ <strong>Control Number:</strong><br>
+                     @if(!empty($order->control_no))
+                         @php
+                             $masterName = App\Models\MasterLogo::first()?->name ?? 'NA';
+                         @endphp
+                         {{ $masterName . '/' . ($order->control_no ?? 'NA') . ' DT ' . ($order->control_date ?? 'NA') }}
+                     @endif
+ </div>
+ </div>
+ </div>