Showing AI reviews for bet-service
Project AI Score ?
62%
Quality Avg ?
63%
Security Avg ?
59%
Reviews ?
92

Review Result ?

solutionbowl/bet-service · 8330530f
This commit adds a new required field 'market_name' to the Bet model and introduces a commented out controller method and route for fetching race markets with user exposure. The addition of 'market_name' improves data completeness. However, commented code reduces codebase cleanliness and maintainability, and the commit message contains a typo ('merket').
Quality ?
60%
Security ?
80%
Business Value ?
70%
Maintainability ?
65%
Issues & Suggested Fixes ?
1AI detects the issue
2Shows file, line, or evidence
3Suggests the fix to apply
Typo In Commit Message
Where commit message
Issue / Evidence typo in commit message
Suggested Fix correct 'merket' to 'market' for clarity
Large Block Of Commented Code
Where src/controllers/bet.controller.js:359
Issue / Evidence large block of commented code
Suggested Fix remove commented code or implement it properly to improve maintainability and clarity
Commented Route
Where src/routes/betRoutes.js:10
Issue / Evidence commented route
Suggested Fix either implement the route fully or remove the commented line to avoid confusion
Adding 'Market Name' From 'Market.marketty...
Where src/controllers/bet.controller.js:237
Issue / Evidence adding 'market_name' from 'market.marketType'
Suggested Fix ensure that this matches the intended field name consistency between the model and controller
'Market Name' Is Marked Required
Where src/models/Bet.js:19
Issue / Evidence 'market_name' is marked required
Suggested Fix verify that all existing data accommodates this to avoid runtime issues
Code Change Preview · src/controllers/bet.controller.js ?
Removed / Before Commit
- diff --git a/src/controllers/bet.controller.js b/src/controllers/bet.controller.js
- index ee1fd09..044b6f0 100644
- bet_type: "racing",
- bet_amount: amount,
- odds_type,
- return_amount: returnAmount,
- bet_status: "ACCEPTED",
- ip_address: req.ip,
- }
- };
- 
- //  const recalculatePlacesExposure = async ({
- //   user_id,
- //   tenant_id,
Added / After Commit
+ diff --git a/src/controllers/bet.controller.js b/src/controllers/bet.controller.js
+ index ee1fd09..044b6f0 100644
+ bet_type: "racing",
+ bet_amount: amount,
+ odds_type,
+         market_name: market.marketType,
+ return_amount: returnAmount,
+ bet_status: "ACCEPTED",
+ ip_address: req.ip,
+ }
+ };
+ 
+ // exports.getRaceMarketsWithUserExposure = async (req, res) => {
+ //   try {
+ //     // const user_id = req.user.userId;
+ //     // const tenant_id = req.tenant ? req.tenant._id : null;
+ //     const { raceId, user_id } = req.body;
+ 
Removed / Before Commit
- diff --git a/src/models/Bet.js b/src/models/Bet.js
- index cbd0e8e..e1e91cd 100644
- enum: ["back", "lay"],
- required: true
- },
- bet_amount: { type: Number, required: true },
- return_amount: { type: Number, default: 0 },
- bet_status: {
Added / After Commit
+ diff --git a/src/models/Bet.js b/src/models/Bet.js
+ index cbd0e8e..e1e91cd 100644
+ enum: ["back", "lay"],
+ required: true
+ },
+   market_name: { type: String, required: true },
+ bet_amount: { type: Number, required: true },
+ return_amount: { type: Number, default: 0 },
+ bet_status: {
Removed / Before Commit
- diff --git a/src/routes/betRoutes.js b/src/routes/betRoutes.js
- index 14569f1..dd2471c 100644
- // Route to place a bet
- router.post("/place", checkTenant, authMiddleware, betController.placeBet);
- router.post("/getGlobalRaceProfitLoss", betController.getGlobalRaceProfitLoss);
- 
- // Get all bets (placeholder for now)
- router.get("/", checkTenant, authMiddleware, betController.getBets);
Added / After Commit
+ diff --git a/src/routes/betRoutes.js b/src/routes/betRoutes.js
+ index 14569f1..dd2471c 100644
+ // Route to place a bet
+ router.post("/place", checkTenant, authMiddleware, betController.placeBet);
+ router.post("/getGlobalRaceProfitLoss", betController.getGlobalRaceProfitLoss);
+ // router.post("/getRaceMarketsWithUserExposure", betController.getRaceMarketsWithUserExposure);
+ 
+ // Get all bets (placeholder for now)
+ router.get("/", checkTenant, authMiddleware, betController.getBets);