AI Review Center

Commit Review Workspace ?

Select a commit on the left to inspect quality, security, business value, findings, and suggested code changes.
Showing AI reviews for bet-service
Project AI Score ?
62%
Quality Avg ?
63%
Security Avg ?
59%
Reviews ?
92

Review Result ?

solutionbowl/bet-service · b6941ab2
This commit adds real-time bet updates through socket events for single and multi bets, improving user experience with live feedback and engagement. The implementation correctly uses emit functions and tracks emitted race IDs for multi bets to avoid duplicate emissions. However, there is some repetition across different controllers and potential absence of input validation or error handling in socket emits, which can introduce bugs or unexpected failures.
Quality ?
75%
Security ?
40%
Business Value ?
80%
Maintainability ?
73%
Issues & Suggested Fixes ?
1AI detects the issue
2Shows file, line, or evidence
3Suggests the fix to apply
Missing Validation
Where src/controllers/bet.controller.js:521
Issue / Evidence potential missing validation or error handling for socket emit
Suggested Fix add try-catch or validate data before emitting
Duplicate Logic
Where src/controllers/multiBet.controller.js:338
Issue / Evidence repeated emission code pattern
Suggested Fix refactor to reuse common emit logic to reduce code duplication and improve maintainability
Missing Validation
Where src/controllers/multiBet.controller.js:339
Issue / Evidence user input (leg.raceId) used without validation
Suggested Fix add validation to ensure raceId is valid string before using and emitting
No Error Handling On Socket Emit
Where src/utils/socketClient.js:79
Issue / Evidence no error handling on socket emit
Suggested Fix consider adding error detection or callback to handle socket emit failures
Vague Description
Where commit message
Issue / Evidence vague description
Suggested Fix improve commit message to clearly describe added real-time bet update feature and benefits
Code Change Preview · src/controllers/bet.controller.js ?
Removed / Before Commit
- diff --git a/src/controllers/bet.controller.js b/src/controllers/bet.controller.js
- index 59abf1e..e59ce46 100644
- const mongoose = require("mongoose");
- const Wallet = require("../models/Wallet");
- const User = require("../models/User");
- const { emitRaceOdds, emitBalanceUpdate } = require("../utils/socketClient");
- const Exposure = require("../models/Exposure");
- const { getTenantExposure, mergeExposure } = require("../utils/exposureHelper");
- const HorseRace = require("../models/HorseRace");
- depth += 1;
- }
- 
-   return { allowed: true };
- };
- 
- const recalculatePlacesExposure = async ({
- selected_runner_ids: selectedRunnerIds,
- });
Added / After Commit
+ diff --git a/src/controllers/bet.controller.js b/src/controllers/bet.controller.js
+ index 59abf1e..e59ce46 100644
+ const mongoose = require("mongoose");
+ const Wallet = require("../models/Wallet");
+ const User = require("../models/User");
+ const { emitRaceOdds, emitBalanceUpdate, emitBetPlaced } = require("../utils/socketClient");
+ const Exposure = require("../models/Exposure");
+ const { getTenantExposure, mergeExposure } = require("../utils/exposureHelper");
+ const HorseRace = require("../models/HorseRace");
+ depth += 1;
+ }
+ 
+   return { allowed: true, user };
+ };
+ 
+ const recalculatePlacesExposure = async ({
+ selected_runner_ids: selectedRunnerIds,
+ });
Removed / Before Commit
- diff --git a/src/controllers/multiBet.controller.js b/src/controllers/multiBet.controller.js
- index c478fc3..2a3fae4 100644
- const User = require("../models/User");
- const mongoose = require("mongoose");
- const { getHierarchyIds } = require("../services/hierarchyService");
- const { emitBalanceUpdate } = require("../utils/socketClient");
- const { calculateMultiBetExposures, updateExposuresAfterLegWin, clearMultiBetExposures } = require("../utils/multiBetExposure");
- 
- const getClientIp = (req) => {
- depth += 1;
- }
- 
-   return { allowed: true };
- };
- 
- /**
- 
- // Calculate and create exposures for all legs
Added / After Commit
+ diff --git a/src/controllers/multiBet.controller.js b/src/controllers/multiBet.controller.js
+ index c478fc3..2a3fae4 100644
+ const User = require("../models/User");
+ const mongoose = require("mongoose");
+ const { getHierarchyIds } = require("../services/hierarchyService");
+ const { emitBalanceUpdate, emitBetPlaced } = require("../utils/socketClient");
+ const { calculateMultiBetExposures, updateExposuresAfterLegWin, clearMultiBetExposures } = require("../utils/multiBetExposure");
+ 
+ const getClientIp = (req) => {
+ depth += 1;
+ }
+ 
+   return { allowed: true, user };
+ };
+ 
+ /**
+ 
+ // Calculate and create exposures for all legs
Removed / Before Commit
- diff --git a/src/utils/socketClient.js b/src/utils/socketClient.js
- index dca6bc1..569329b 100644
- s.emit("balanceUpdate", { userId, balance });
- };
- 
- const getExposureData = async ({ raceId, tenantId = null }) => {
- const match = {
- race_id: new mongoose.Types.ObjectId(raceId),
- ]);
- };
- 
- module.exports = { getSocket, emitRaceOdds, emitBalanceUpdate };
Added / After Commit
+ diff --git a/src/utils/socketClient.js b/src/utils/socketClient.js
+ index dca6bc1..569329b 100644
+ s.emit("balanceUpdate", { userId, balance });
+ };
+ 
+ const emitBetPlaced = async (raceId, bet) => {
+   const s = getSocket();
+ 
+   s.emit("bets", { raceId: String(raceId || ""), bet });
+ };
+ 
+ const getExposureData = async ({ raceId, tenantId = null }) => {
+ const match = {
+ race_id: new mongoose.Types.ObjectId(raceId),
+ ]);
+ };
+ 
+ module.exports = { getSocket, emitRaceOdds, emitBalanceUpdate, emitBetPlaced };